search

AG3NTZ3R0 / cnbc

A Python package that wraps CNBC API endpoints and returns financial data in JSON.
https://pypi.org/project/cnbc/
GNU General Public License v3.0
4 stars 0 forks source link

Restructure Source #2

Closed AG3NTZ3R0 closed 8 months ago

AG3NTZ3R0 commented 8 months ago

A PR to restructure the source code based upon best practices in the industry.

AG3NTZ3R0 commented 8 months ago

I need to continue to rethink the way the new APIWrapper class will be leveraged. It is 100% the right way to head in this scenario as there is sooo much duplicate code. It's just trying to make the correct design choices.

AG3NTZ3R0 commented 8 months ago

I need to continue to rethink the way the new APIWrapper class will be leveraged. It is 100% the right way to head in this scenario as there is sooo much duplicate code. It's just trying to make the correct design choices.

I've completed the class. The next step is to expand the documentation in the docstrings of the old methods into the README.md of the repository. Afterwards the old methods will be removed and a single class will be leveraged.

AG3NTZ3R0 commented 8 months ago

I've completed the class. The next step is to expand the documentation in the docstrings of the old methods into the README.md of the repository. Afterwards the old methods will be removed and a single class will be leveraged.

I need to complete the documentation in the README.md, but the rest of the work is done.