AGHSEagleRobotics / frc1388-2022

FRC 2022 - Rapid React
2 stars 0 forks source link

Guest Mode drive speed control #76

Open jtechau opened 1 year ago

jtechau commented 1 year ago

A suggestion from Paul:

Would we want to allow for Driver controller to vary Guest speed? Could verify by simply driving robot with Guest controller and adjusting on the fly. Would allow for a wider range of guests. Possible control could be using Enable Guest mode to progressively increase guest speed. When first transitioning to enabled mode, always start at the slowest speed.

I suspect using X and Y to vary the speed might make more sense, as that way you can vary the speed both up and down without disabling Guest Mode.

AlexKaplan1388 commented 1 year ago

Added methods for Guest Mode making increases of 0 to 1 (can change later to match robot)

jtechau commented 1 year ago

In commit a9293f772f7d5ecda32549f7182763451e518610:

It doesn't look like increaseSpeed() is called anywhere. I would suggest that setGuestMode() should first check to see if enabled is already true; if so, increase the speed, otherwise set the speed to minimum.