search

AGSPhoenix / sheepit-docker

A lightweight docker container for the SheepIt! render farm
Creative Commons Zero v1.0 Universal
28 stars 9 forks source link

Start script does not handle signals #3

Open AGSPhoenix opened 8 years ago

AGSPhoenix commented 8 years ago

With the new signal handling in the client, being able to send a ctrl-c via docker kill would be a nice feature.

CryoRig commented 7 years ago

docker stop {dockername} works fine for me... if you still want a ctrl-c, i can look into it, shouldn't be hard

AGSPhoenix commented 7 years ago

My desire with this was to have the client's graceful shutdown capability usable from docker commands. Given that docker stop defaults to a 10 second delay before killing the container though, and an ongoing render could take upwards of half an hour to complete, that may simply not be feasible. If you want to take a look, let me know how it goes.

DaCoolX commented 5 years ago

Since this issue was created docker runtime added support for the --init option, If enabled it just interjects the tini init system, which handles signal handling and process reaping automatically (the latter won't be an issue in sheepit's case most likely) and doesn't interfere with anything else. Though it would most likely kill the render process immediately.