Getting build error while building git-crypt on a docker based on ubuntu:14.04

richtera commented 7 years ago

g++ -Wall -pedantic -Wno-long-long -O2 -Wno-deprecated-declarations   -c -o crypto-openssl.o crypto-openssl.cpp
crypto-openssl.cpp:74:11: error: field ‘ctx’ has incomplete type ‘HMAC_CTX {aka hmac_ctx_st}’
  HMAC_CTX ctx;
           ^~~
In file included from /usr/include/openssl/evp.h:14:0,
                 from /usr/include/openssl/hmac.h:15,
                 from crypto-openssl.cpp:36:
/usr/include/openssl/ossl_typ.h:102:16: note: forward declaration of ‘HMAC_CTX {aka struct hmac_ctx_st}’
 typedef struct hmac_ctx_st HMAC_CTX;
                ^~~~~~~~~~~
crypto-openssl.cpp: In destructor ‘Hmac_sha1_state::~Hmac_sha1_state()’:
crypto-openssl.cpp:88:27: error: ‘HMAC_cleanup’ was not declared in this scope
  HMAC_cleanup(&(impl->ctx));
                           ^
<builtin>: recipe for target 'crypto-openssl.o' failed

Unfortunately I am not quite sure how to track down a fix.

AGWA commented 7 years ago

What version of OpenSSL are you building against? Note that git-crypt doesn't support 1.1 yet.

richtera commented 7 years ago

Got it. That's got to be it

kalbasit commented 7 years ago

@AGWA are you planning on porting git-crypt to openssl-1.1?

artem-sidorenko commented 7 years ago

@richtera I'm building the git-crypt packages which are missing in distros via OBS, maybe this helps

richtera commented 7 years ago

I just switched distro and was fine. But I think it does need to be addressed eventually. I have not played with OBS recently.

dusty-phillips commented 7 years ago

This is breaking git-crypt under the new Fedora 26 beta unless you install compat-openssl10-devel

florenthemmi commented 7 years ago

Not compiling since Debian 9.0

> openssl version
OpenSSL 1.1.0f  25 May 2017

AGWA commented 7 years ago

Closed in 553c1b03876e174b117bb5250593217418f425a4

AGWA / git-crypt

Getting build error while building git-crypt on a docker based on ubuntu:14.04 #111