search

AGWA / git-crypt

Transparent file encryption in git
https://www.agwa.name/projects/git-crypt/
GNU General Public License v3.0
8.28k stars 479 forks source link

eclipse: git-crypt filter stopped working #205

Closed Andrei-Pozolotin closed 4 years ago

Andrei-Pozolotin commented 4 years ago

please see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=561666

alerque commented 4 years ago

I don't see how this is a git-crypt issue. Per your own report linked above it continues to work just fine from the CLI and nothing has changed on this end. This issue should be closed, there doesn't seem to be anything to do here. A change to how Eclipse handles path resolution and quoting is irrelevant here.

By the way if your PATH is setup properly you can call it as either git-crypt ... or git crypt ....

Andrei-Pozolotin commented 4 years ago

can you please link here git spec on config filter entry format: why quoting is needed by git-crypt

alerque commented 4 years ago

Quoting is used just like anywhere in a shell: to avoid issues if the path includes a space or other special characters. Rather than checking the resolved binary name and path for issues, it just quotes it by default to be safe. This should be just fine. Whatever Eclipse is doing is wrong, they should handle this as an already ready to use shell command the way POSIX would handle it, not try to add more escaping.

Andrei-Pozolotin commented 4 years ago

confirmed by eclipse, thank you.