AGWA / git-crypt

Transparent file encryption in git
https://www.agwa.name/projects/git-crypt/
GNU General Public License v3.0
8.1k stars 472 forks source link

expand key ID references in commit messages #253

Closed ktdreyer closed 2 years ago

ktdreyer commented 2 years ago

https://evil32.com/ explains why we should reduce the use of 32-bit key IDs.

git-crypt writes commit messages with short key IDs:

// given a key fingerprint, return the last 8 nibbles
std::string gpg_shorten_fingerprint (const std::string& fingerprint)
{
    return fingerprint.size() == 40 ? fingerprint.substr(32) : fingerprint;
}

Could we write the full fingerprints instead?

AGWA commented 2 years ago

Good idea.

To be clear, git-crypt already uses exclusively full fingerprints internally. The commit message was the only place short IDs were being used.