AGWA / git-crypt

Transparent file encryption in git
https://www.agwa.name/projects/git-crypt/
GNU General Public License v3.0
8.1k stars 472 forks source link

Doc: Add note about AutoCRLF issue #268

Open maxisam opened 1 year ago

maxisam commented 1 year ago

264

alerque commented 1 year ago

If this is a necessary configuration on Windows shouldn't git-crypt itself be adding it the attributes?

maxisam commented 1 year ago

I think it is because autocrlf is default/recommend to auto in Windows. I believe it might work just fine with autocrlf=false. I don't write c++ for 20 years, so I will not mess around the code. But I think this deserves a note in the Readme, since it caused me couple hours to figure this out.

alerque commented 1 year ago

Yes I understand how that setting would cause unexpected line endings, the surprising bit to me is that this hasn't been bumped into before by other Windows users since that's kind of the default (if not so much de facto) usage.

maxisam commented 1 year ago

Yeah, that makes two of us. But I don't use autocrl = true until 2 years ago. And this project doesn't have windows build until 0.7.0. So I guess not so many windows users here.