AHilyard / EquipmentCompare

A mod for Minecraft 1.16.5 that makes it easier to compare equipment.
Other
10 stars 9 forks source link

Issues with comparison for gear with Tiers applied (TierZ, Tiered2, Tierify) #39

Open 2ndRecon opened 4 months ago

2ndRecon commented 4 months ago

============================= MC Version - Fabric - 1.20.1 Mod Version - Fabric 1.3.8 -Iceberg 1.1.18 -Cloth Config 11.1.106 -Forge Config Port 8.0.0 Modpack Name - Prominence 2 - Ver. 2.8.7

[Tierify version is 1.1.0, derived from Tiered2, which was derived from TierZ]

When comparing items from a Vanilla weapon for instance, it seems to work fine. e.g. 'Give' a vanilla weapon like a sword, axe etc.

Example: You spawn into a new world and have it set to give you a Vanilla MC Weapon, like a sword. That works fine, and in fact I can compare that Vanilla MC weapon to pretty much ANY modded weapon in fact.

However, holding a Modded Weapon or Vanilla 'Tiered' weapon results in either no comparison shown OR a brief 'flash' as if it's trying to pop up a Compare window, but it blinks and never stays.

For most things there's simply no indication at all that it's trying to compare. However, comparing a True 'Vanilla' Weapon / Tool to a Modded one held in hand ALWAYS results in a comparison. So, it seems it can enumerate / detect the attributes of a true vanilla weapon just fine AND it can enumerate the values of a Tiered weapon that's held, but not in comparison to anything else.

It appears to me that something with the Tierify is causing it to not see the item correctly.

NOTE: The pack in question is Prominence 2 an RPG Pack. Tierify controls the level of weapons when crafting. So, when you craft even a vanilla sword in a Crafting Table, with sticks and cobble, the resulting stone sword is given a randomly generated / rolled 'Rarity' or 'Tier'.

Weapons that ARE NOT Tiered don't seem to be a problem. However, any weapons that don't have a tier such as those that may be coming from some other mod, perhaps, seem to also work.

Thank you and I am attaching Screen Shots comparing the issue.

Screenshot 1 - Comparing a Tiered Wooden Sword to a held Vanilla Stone Sword. Screenshot 2 - Comparing a Vanilla Stone Sword to a held Tiered Wooden Sword. Screenshot 3 - Comparing a Tiered Modded Wand to a Held Vanilla Stone Sword Screenshot 4 - Comparing a Vanilla Stone Sword to a Held Tiered Modded Wand

As you'll see from the screenshots; it doesn't appear that I can compare a 'Modded Tiered' Weapon, to anything else. However, I CAN successfully compare pretty much any Vanilla item, to a modded / tiered counterpart. TieredWooden-HeldStone

VanillaStone-TieredWooden TieredWand-HeldStone

VanillaStone-ModdedWand