AHilyard / Iceberg

A library containing events, helpers, and utilities to make modding easier.
Other
23 stars 10 forks source link

Add Embeddium Support or correctly add incompat #81

Open MundM2007 opened 1 month ago

MundM2007 commented 1 month ago

Currently in the latest Version of Iceberg for neoforge (1.2.8) it is entitrely possible to launch the game with embeddium installed. As it is listed as incompatible in the neoforge.mods.toml this may cause errors with other mods and crash the game randomly. I haven't verified this though, just heard it.

What I would recommend, though, instead of fixing the incompat Statement is to actually readd embeddium support, which as by the latest commit only is about 20 lines (Not counting the ones that are universal between embeddium and sodium). Some people will always want to use embeddium and they won't switch to Sodium in thier Pack but rather not use your mods and find alternatives. Also as of I right now Sodium has many incompatabilities with content mods and bigger modpacks, so I've heard.

I, hereby suggest the readdition of embeddium support, to give user a choice and also be compatible with larger packs. Thanks.

MundM2007 commented 1 month ago

Or as a third option, just remove the incompat statement to not cause confusion to people working with the mod, as it seems to work after you have fixed the crash in https://github.com/AHilyard/Iceberg/issues/80

NovaViper commented 1 month ago

I actually second this.. especially since Sodium support on NeoForge in particular just came out not too long ago, so there aren't many mods (and modpacks even) on NeoForge that supports Sodium specifically. I say at least wait for the complete abandonment of Embeddium until Sodium support on NeoForge is fully matured.

MundM2007 commented 1 month ago

So to restate the options that you face: