AHilyard / LegendaryTooltips

A mod for Minecraft that adds fancy tooltips for rare items as well as tooltip customization options.
Other
29 stars 14 forks source link

1.20.1 fabric - incompatibility with TieredZ when render_item_model enabled #110

Closed Linguardium closed 1 year ago

Linguardium commented 1 year ago

in single player, it generates new tiered items/itemstacks in the inventory as one picks up/puts down, hovers over items. the nbt is not actually changed, this appears to be a clientside issue (Though single player shares object memory so it becomes serverside in single player)

setting render_item_model to EQUIPMENT or ALL will cause the issue. setting it to NONE removes the issue leading me to believe its an issue with itemstack modification/recreation during rendering?

Linguardium commented 1 year ago

issue is with iceberg equipping items clientside during a render call. since equipping items normally happens serverside, the tiered code didnt check sidedness during tier generation