search

AHilyard / MerchantMarkers

A mod for Minecraft 1.17.1+ to display markers above villagers based on their profession.
Other
4 stars 5 forks source link

Merchant Markers quadruples my game's launch time. #12

Closed JENOVAAbsolute closed 2 years ago

JENOVAAbsolute commented 2 years ago

Without the mod, Minecraft takes roughly 25 seconds to launch. Applying this mod increased that to just over a minute and a half. The results were consistent. Tested three times.

latest.log

AHilyard commented 2 years ago

Interesting, I've just done some timing tests and received the following results with Forge 40.1.73:

no mods: 56 seconds
try 2: 52 seconds
only merchant markers: 44 seconds
try 2: 50 seconds
merchant markers + xaero minimap: 49 seconds
try 2: 48 seconds

This is my elapsed time from pressing "Play" in the launcher to the game's main menu being fully loaded. Can I get a mod list, and a log file from when you don't have Merchant Markers loading?

JENOVAAbsolute commented 2 years ago

Sure. I have more mods now than I did last last time, as I'm building a modpack. The image below is a screenshot of my modlist without Merchant Markers. Load time was the same as yesterday. Not even 30 seconds. There will be a log file without the mod as well.

latest.log

AHilyard commented 2 years ago

I've tried installing what I can from this list and testing, but I'm still not getting any significant slowdown. Is there a reason you've renamed all of these files? It makes it very difficult to troubleshoot without the normal filenames, since I don't know exactly what you are using. It would be very helpful if you could help troubleshoot by providing a minimal reproducible mod set.

AHilyard commented 2 years ago

Alternatively if you're using the CurseForge launcher, you can export the profile with config and mods and attach it so I can easily test the same setup.

JENOVAAbsolute commented 2 years ago

That is my OCD kicking in. I do not use the CurseForge launcher unfortunately. I have a text file with links to every mod in the mod pack I'm putting together (so far). Keep in mind I have removed some of the mods that I had before. I'll put that here. I apologize for the inconvenience, as I know that is a habit that would make things harder for you.

Modlist.txt

JENOVAAbsolute commented 2 years ago

I'm going to assume there's something on my end going on. I've temporarily removed most client side mods and am adding them back once the mandatory mods are all in and tested. I'll worry about this again once I'm at that point. Though if you do find anything out, let me know.

My friends I'm putting this pack together for to play with want your mod collection for the extra RPG feel. Can't say I disagree with them. Advancement plaques in particular is my favorite from your mods.