MerchantMarkers causes a wired issue on MC 1.19.3 Forge 44.1.5 when using a ressource pack

SubSonicEr commented 1 year ago

Hey there,

I really like the useful markers over every trader. Unfortunately the mod causes for MC 1.19.3 Forge 44.1.5. a wired issue when using a ressource pack.

Starting MC without an aktivated ressource pack MC seems to start normally. When starting MC with a previously activated ressource pack MC is crashing. You need to start MC again and MC is loaded without an activated ressource pack. Additionally a lot of mod configs, key binds etc... are resetted. Apparently you need to deactivate the ressource pack before closing MC to start MC without crashing again.

I'm getting the following crash log with this wired issue:

SubSonicEr commented 1 year ago

---- Minecraft Crash Report ---- // Don't be sad, have a hug! <3

Time: 2023-01-22 18:51:24 Description: Unexpected error

java.lang.NullPointerException: Cannot invoke "net.minecraft.client.player.LocalPlayer.m6117()" because "this.f91074" is null at net.minecraft.client.Minecraft.m91279(Minecraft.java:1957) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m91398(Minecraft.java:1793) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m91383(Minecraft.java:1097) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m91374(Minecraft.java:713) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.m239872(Main.java:212) ~[1.19.3-forge-44.1.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:51) ~[1.19.3-forge-44.1.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {} at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {} at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {} at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {} at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:27) ~[fmlloader-1.19.3-44.1.5.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at net.minecraft.client.Minecraft.m91279(Minecraft.java:1957) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} -- Last reload -- Details: Reload number: 1 Reload reason: initial Finished: Yes Packs: dynamic_asset_generator:excavated_variants:assets, vanilla, mod_resources, file/Faithful+64x.zip, dynamic_asset_generator:dynamic_asset_generator:builtin_assets, defaultresources_global, SolarFlux Recovery: Yes Recovery reason: java.util.concurrent.CompletionException: java.lang.IllegalStateException: zip file closed at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) Caused by: java.lang.IllegalStateException: zip file closed at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:831) at java.base/java.util.zip.ZipFile.getInputStream(ZipFile.java:360) at TRANSFORMER/minecraft@1.19.3/net.minecraft.server.packs.resources.IoSupplier.m247182(IoSupplier.java:17) at TRANSFORMER/minecraft@1.19.3/net.minecraft.server.packs.resources.Resource.m215507(Resource.java:46) at TRANSFORMER/minecraft@1.19.3/net.minecraft.client.renderer.texture.SpriteLoader.m245083(SpriteLoader.java:132) at TRANSFORMER/minecraft@1.19.3/net.minecraft.client.renderer.texture.atlas.SpriteSource$Output.m261059(SpriteSource.java:19) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ... 6 more

Stacktrace: at net.minecraft.client.ResourceLoadStateTracker.m168562(ResourceLoadStateTracker.java:49) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:classloading,pl:rei_plugin_compatibilities:B} at net.minecraft.client.Minecraft.m91354(Minecraft.java:2326) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m91374(Minecraft.java:735) ~[client-1.19.3-20221207.122022-srg.jar%23748!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:rei_plugin_compatibilities:B,pl:mixin:APP:mixins.hammerlib.json:client.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:META-INF/theadditionsmod.mixins.json:mixinMinecraft,pl:mixin:APP:itemphysic.mixins.json:MinecraftMixin,pl:mixin:APP:the_bumblezone.mixins.json:client.MinecraftMixin,pl:mixin:APP:ae2.mixins.json:PickColorMixin,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientAccessor,pl:mixin:APP:bettercombat.mixins.json:client.MinecraftClientInject,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:tofucraft.mixins.json:client.MinecraftMixin,pl:mixin:APP:mixin.dynamic_asset_generator.json:MinecraftMixin,pl:mixin:APP:iceberg.mixins.json:MinecraftMixin,pl:mixin:APP:zergatul.freecam.mixin.json:MixinMinecraft,pl:mixin:APP:securitycraft.mixins.json:camera.MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.m239872(Main.java:212) ~[1.19.3-forge-44.1.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:51) ~[1.19.3-forge-44.1.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {} at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {} at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {} at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {} at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:27) ~[fmlloader-1.19.3-44.1.5.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.8.jar:?] {} at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] {}

AHilyard commented 1 year ago

Looking through this crash log, I don't see anything that would point to Merchant Markers being involved. Was there some reason you suspected Merchant Markers to be the cause of the crash?

SubSonicEr commented 1 year ago

Yeah I've used trial and error by adding and deleting all my mods and I found out "Merchant Markers" which is causing my issue. Sry for stealing your time, I think there is an incompatibility with one of my other used mods. So it doesn't make sense to locate the issue. But thx for the fast reply. Maybe there is an unforseen fix in a future upgrade :)

Enjoy your time :)

r0zemary commented 1 year ago

Looking through this crash log, I don't see anything that would point to Merchant Markers being involved. Was there some reason you suspected Merchant Markers to be the cause of the crash?

Caused by: java.lang.NoSuchMethodError: 'boolean com.anthonyhilyard.iceberg.util.DynamicResourcePack.registerResource(net.minecraft.class_3264, net.minecraft.class_2960, java.util.function.Supplier)' at com.anthonyhilyard.merchantmarkers.compat.XaeroMinimapHandler.setupDynamicIcons(XaeroMinimapHandler.java:191) ~[MerchantMarkers-1.19.3-fabric-1.3.0.jar:?] at com.anthonyhilyard.merchantmarkers.compat.XaeroMinimapHandler.clearIconCache(XaeroMinimapHandler.java:72) ~[MerchantMarkers-1.19.3-fabric-1.3.0.jar:?] at com.anthonyhilyard.merchantmarkers.compat.XaeroMinimapHandler.method_14491(XaeroMinimapHandler.java:289) ~[MerchantMarkers-1.19.3-fabric-1.3.0.jar:?] at net.minecraft.class_4013.method_29490(class_4013.java:15) ~[client-intermediary.jar:?] at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787) ~[?:?] ... 13 more I'm getting this log on Fabric 1.19.3 , so this seems to be an issue on both versions of the mod. I wrote a more detailed issue about it on the Iceberg page, thinking that Iceberg was causing the crash.

r0zemary commented 1 year ago

Description:

Loading any new resource pack causes the "loading screen" to cut out at a random point and all resource packs to be disabled.

Versions:

Iceberg-1.19.3-fabric-1.1.4.jar
Xaeros_Minimap_22.17.1_Fabric_1.19.3.jar
MerchantMarkers-1.19.3-fabric-1.3.0.jar

Steps to reproduce:

Start Minecraft with all three mods loaded
Go to the resource pack menu and try to enable a resource pack
Enter the resource pack menu again, and you'll see that there are no resource packs loaded except vanilla

Log:

r0zemary commented 1 year ago

Can also confirm that Iceberg without MerchantMarkers or MerchantMarkers without Xaero's works just fine

PlayfulPiano commented 7 months ago

you have no idea how much of a blessing it is finding this issue.

i've been trying to troubleshoot my own issues going on with my modpack i've been using, and same as yours, it turns out to be merchantmarkers causing the problems. crash-2023-11-15_17.03.43-client.txt

Here's my own crash report regarding the issue, only for forge 1.20.1.

UltimatChamp commented 4 months ago

How to Reproduce:

Mods:
- Fabric API
- Forge Config API Port
- Iceberg
- *Merchant Markers
- *Xaero's Minimap
This issue happens regardless of any RP (didn't saw any wierd stuff with Fast Better Grass or any light RP, though)!
Happens after restarting the game.
Nvidium prevents it...?

Probably because of this:

[13:27:50] [Render thread/WARN]: Injection warning: LVT in net/minecraft/class_332::method_51435(Lnet/minecraft/class_327;Ljava/util/List;IILnet/minecraft/class_8000;)V has incompatible changes at opcode 161 in callback iceberg.mixins.json:GuiGraphicsMixin from mod iceberg->@Inject::storeLocalsOptifine(Lnet/minecraft/class_327;Ljava/util/List;IILnet/minecraft/class_8000;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;Ljava/lang/Object;IIIILorg/joml/Vector2ic;)V.
Expected: [Ljava/lang/Object;, I, I, I, I, Lorg/joml/Vector2ic;]
Found: [I, I, I, I, Lorg/joml/Vector2ic;]
Available: [I, I, I, I, Lorg/joml/Vector2ic;]

Textures Broken:

IJuanTM commented 2 months ago

Did anyone ever found out what the incompatibility was exactly?

I am making a mod pack with around 200 mods now and enabling Merchant Markers causes my game to infinitely get stuck at the Mojang screen. Disabling this mod and it works fine again...

I have been troubleshooting for literal weeks now lol, and finally found out it was this mod causing my game to not load. Have had it working before in a smaller mod pack though, but I have no clue what possible incompatibility could cause this.

The logs also don't say anything when it gets stuck, just the regular mess of debug stuff and warnings that are unrelated, no crash logs or anything either.

When using the Memory Usage Screen mod I can see that it goes from making large jumps in memory usage to ticking up with 1mb every second out of nowhere and keeps doing that forever (let it run for at least half an hour once, launching usually takes about 2 minutes). It doesn't do this without Merchant Markers. Logs also stop updating after it goes to the weird slow memory usage (as if the game stops loading resources at all).

AHilyard / MerchantMarkers