search

AHilyard / MerchantMarkers

A mod for Minecraft 1.17.1+ to display markers above villagers based on their profession.
Other
4 stars 5 forks source link

Crash with FTB Chunks #21

Open pokesmells opened 1 year ago

pokesmells commented 1 year ago

https://mclo.gs/WWEX0M7

Consulting with the FTB team, and they mentioned that Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector redirectIconDraw(Ldev/ftb/mods/ftbchunks/integration/MapIcon;Ldev/ftb/mods/ftbchunks/client/MapType;Lnet/minecraft/class_4587;IIIIZ)V in merchantmarkers.mixins.json:FTBChunksClientMixin from mod merchantmarkers failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap MerchantMarkers-1.19.1-fabric-refmap.json

Is mixing into their mod which is causing the crash.

Sythiex commented 1 year ago

I am also seeing this crash on forge 1.18.2. It started occurring after updating FTB Chunks to version 1802.3.14 or higher. Version 1802.3.13 seems to work fine.

Forge: 40.2.0 Merchant Markers: 1.3.0 +most recent versions of all dependencies

desht commented 1 year ago

There have been multiple issues raised against the latest version of FTB Chunks now, all due to the use of this mixin.

I would appreciate if the author of Merchant Markers fixed this problem ASAP, and stopped using a mixin like this. Mixins are intended for use with vanilla code, NOT other mods. If there's functionality you need from Chunks that you can't get by default, please talk to us about it and we'll do what we can to help.

desht commented 1 year ago

@AHilyard we continue to receive issues blaming FTB Chunks for what is a problem caused by your mixin. Please fix it.