AHilyard / MerchantMarkers

A mod for Minecraft 1.17.1+ to display markers above villagers based on their profession.
Other
4 stars 5 forks source link

Merchant Markers Causes resourcepacks to not Load #24

Open papamaionise opened 1 year ago

papamaionise commented 1 year ago

I have tested with and with out this mod and yes it causes the issue

rumrunner0 commented 10 months ago

This is true. I'm so irritated. This mod is causing issues with resourcepacks.

Okay, let's chill.

Dear developer, please review your logic related to resource pack processing.

The bug (in my particular case)

When this mod is installed with some resource packs (the issue may only occur with incompatible ones, I don't know), the game resets all resource packs upon loading, displaying a message like 'resources loading failed.' The MOST RIDICULOUS aspect is that this happens completely randomly! Everything can be okay for about 4 or 6 times in a row, but on the 7th, the issue appears. I can't even imagine why.

rumrunner0 commented 10 months ago

This is urgent, need a fix, please

rumrunner0 commented 10 months ago

Sorry for my emotions. I've put SO MUCH effort into locating the issue

Kentaarka commented 10 months ago

I got the same problem, using MerchantMarkers-1.20.1-forge-1.3.3 and texture pack John Smith Legacy 1.20.1 v4. On starting Minecraft the message "ressource loading failed" appears and Minecraft crashes with "Cannot invoke "net.minecraft.client.player.LocalPlayer.m6117()" because "this.f91074" is null". The next time I start mc all texture packs are disabled and mc starts without any problems. But the next start after activating the texture pack will crash again. And this behavious disappears when I remove MerchantMarkers.

IJuanTM commented 7 months ago

Similar issue here, after days of disabling and enabling mods I finally figured out which mod was causing issues.

For me enabling this mod causes my game to not load and it stays stuck at the Mojang screen. Disable this mod and it all works fine again. It is probably some compatibility issue with another mod, but I have no idea which of the 200 in my mod pack it could be...

DaftHunk commented 7 months ago

Oh god so this is the one, I spend so much days finding the cause too...

KyrDerz commented 5 months ago

Same. Few days. Couldn't have imagined this is what breaks loading, and messes with sounds.

Mikaaah commented 4 months ago

Same issue here, Getting

Description: Rendering overlay

java.lang.IllegalStateException: zip file closed

When Enabling Resourcepacks by force, but only when merchant markers is within the pack.