AI-Engineer-Foundation / agent-protocol

Common interface for interacting with AI agents. The protocol is tech stack agnostic - you can use it with any framework for building agents.
https://agentprotocol.ai
MIT License
999 stars 120 forks source link

use any-cloud-storage to abstract artifact storage #104

Open nalbion opened 9 months ago

nalbion commented 9 months ago

Pull Request

Description

Use https://github.com/nalbion/any-cloud-storage to abstract storage of artifacts

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

References, Fixes and Closes

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **agentprotocolai** | ⬜️ Ignored ([Inspect](https://vercel.com/ai-engineers-foundation/agentprotocolai/EZmgVrSNodGsoTdqqWsAwRsZRwq5)) | [Visit Preview](https://agentprotocolai-git-fork-nalbion-cc196c-ai-engineers-foundation.vercel.app) | | Feb 14, 2024 6:46am |
jzanecook commented 8 months ago

I believe these changes would not be a standard agent protocol SDK that's 1:1 with the spec. For changes to the spec, there needs to be an RFC written out that details the changes.

However, I can see this being useful for the js sdk, and I'm thinking that what we could do here is take some of these changes and incorporate it into some example agents. If you can take a look at the config options RFC in the V2 branch and see if that "changes the game" per se for your implementations.

nalbion commented 8 months ago

@jzanecook I don't think that the implementation of createArtifact(), registerCreateArtifact() and registerGetTaskArtifact() have anything to do with the spec.

I'd be happy to move AnyCloudArtifactStorage and ArtifactStorageFactory into a README or examples and remove the dependency on any-cloud-storage. Maybe the example could show how artifact_provider could be used to configure the storage for each request?