AI-Engineer-Foundation / agent-protocol

Common interface for interacting with AI agents. The protocol is tech stack agnostic - you can use it with any framework for building agents.
https://agentprotocol.ai
MIT License
1.01k stars 120 forks source link

BugFix : Models : updated additional_input #89

Closed vignesh14052002 closed 10 months ago

vignesh14052002 commented 11 months ago

Pull Request

This pull request contains a fix for v1 API endpoints for create task and execute step not accepting additional_input parameter , For more details refer this issue #82

Description

Issue :

v1 API endpoints for create task [POST] /ap/v1/agent/tasks and execute step [POST] /ap/v1/agent/tasks/{taskid}/steps not accepting additional_input parameter

Reason :

The pydantic models Task and Step has not configured additional_input property

Changes :

Made additional_input property to type Optional[Dict[str, Any]] in python sdk

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

References, Fixes and Closes

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **agentprotocolai** | ⬜️ Ignored ([Inspect](https://vercel.com/ai-engineers-foundation/agentprotocolai/HAJtpnr5AEnJR53ZhM7eP6wc3iL5)) | [Visit Preview](https://agentprotocolai-git-fork-vignesh-55b576-ai-engineers-foundation.vercel.app) | | Jan 23, 2024 7:04am |
hackgoofer commented 10 months ago

@vignesh14052002 Can you join the meeting with us at 9:30am PST at the foundation discord? https://discord.com/invite/bJnNh666C3

Let's get this merged and resolved.

hackgoofer commented 10 months ago

@jzanecook to make sure that the test suite covers the case.

jzanecook commented 10 months ago

@jzanecook to make sure that the test suite covers the case.

Checked the test suite, this is currently failing.

Here's the output: image

vignesh14052002 commented 10 months ago

@jzanecook how to run the test suite? i ran packages\sdk\python\examples\minimal.py to start the server and ran both testing_suite/local_test.sh and testing_suite/test.sh

image

vignesh14052002 commented 10 months ago

@jzanecook maybe the failed test cases are from js-sdk , i see the test cases are already failing in main , so reverted my js-sdk changes , you can review the python part alone

vignesh14052002 commented 10 months ago

@vignesh14052002 Can you join the meeting with us at 9:30am PST at the foundation discord?

sure

hackgoofer commented 10 months ago

https://agentprotocol.ai/compliance here is how you test.

vignesh14052002 commented 10 months ago

https://agentprotocol.ai/compliance here is how you test.

@hackgoofer checked it , test cases passed

vignesh14052002 commented 10 months ago

@hackgoofer @jzanecook Remainder! , seems you forgot to merge this PR