Update xpk.py - Githubissues

AI-Hypercomputer / xpk

xpk (Accelerated Processing Kit, pronounced x-p-k,) is a software tool to help Cloud developers to orchestrate training jobs on accelerators such as TPUs and GPUs on GKE.

Apache License 2.0

81 stars 23 forks source link

Update xpk.py #92

Closed sadikneipp closed 7 months ago

sadikneipp commented 8 months ago

Remove server argument from proxy server arguments.

Fixes / Features

Without this change, the proxy server was not starting up for me. I'd get an unknown argument error.

Testing / Documentation

This unblocked me from running a workload.

RoshaniN commented 8 months ago

Hey Sadi, I am curious to know if any logic around this argument was recently changed in Pathways, as I did not face this issue.

Obliviour commented 8 months ago

Looking at the Build Test failure, you may need to create a PR from a branch instead of a fork. I provided you permissions to do this, just in case.

sadikneipp commented 7 months ago

Since it's such a small change @RoshaniN aligned with me to incorporate this PR in #100 . I'll close this PR.