AI-Planning / pddl

Unquestionable PDDL 3.1 parser
https://ai-planning.github.io/pddl/
MIT License
85 stars 27 forks source link

Fixing three subtle bugs with numerics in problem files. #103

Closed haz closed 10 months ago

haz commented 10 months ago

Fixes

Does two important things to address #99 and another bug found:

  1. NUMBER was matching on anything with a space (so 5 3 was a single number)
  2. The f-expressions in the problem file were pointing back to the domain definition, and thus trying to wrap in Variables.
  3. (update) Added another fix for #101, which now allows equality in metric goal conditions.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (514d568) 88.10% compared to head (260fe74) 88.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AI-Planning/pddl/pull/103/graphs/tree.svg?width=650&height=150&src=pr&token=FG3ATGP5P5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning)](https://app.codecov.io/gh/AI-Planning/pddl/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== + Coverage 88.10% 88.33% +0.22% ========================================== Files 25 25 Lines 1791 1791 Branches 332 332 ========================================== + Hits 1578 1582 +4 + Misses 154 149 -5 - Partials 59 60 +1 ``` | [Flag](https://app.codecov.io/gh/AI-Planning/pddl/pull/103/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AI-Planning/pddl/pull/103/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) | `88.33% <ø> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/AI-Planning/pddl/pull/103/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning)