search

AI-Planning / pddl

Unquestionable PDDL 3.1 parser
https://ai-planning.github.io/pddl/
MIT License
85 stars 27 forks source link

An effect part of the condeff should be AndEffect and not And. #119

Closed haz closed 2 months ago

haz commented 2 months ago

Minor fix for #118

haz commented 2 months ago

Probably best to wait for #120 to be resolved before this is merged (so we can be sure nothing's broken).

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.07%. Comparing base (fef6c74) to head (21c17ee).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AI-Planning/pddl/pull/119/graphs/tree.svg?width=650&height=150&src=pr&token=FG3ATGP5P5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning)](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== + Coverage 87.98% 88.07% +0.08% ========================================== Files 24 24 Lines 1773 1752 -21 Branches 333 329 -4 ========================================== - Hits 1560 1543 -17 + Misses 152 148 -4 Partials 61 61 ``` | [Flag](https://app.codecov.io/gh/AI-Planning/pddl/pull/119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AI-Planning/pddl/pull/119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) | `88.07% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning) | Coverage Δ | | |---|---|---| | [pddl/\_validation.py](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?src=pr&el=tree&filepath=pddl%2F_validation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#diff-cGRkbC9fdmFsaWRhdGlvbi5weQ==) | `91.41% <100.00%> (ø)` | | | [pddl/logic/effects.py](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?src=pr&el=tree&filepath=pddl%2Flogic%2Feffects.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#diff-cGRkbC9sb2dpYy9lZmZlY3RzLnB5) | `86.44% <100.00%> (+1.44%)` | :arrow_up: | | [pddl/parser/domain.py](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?src=pr&el=tree&filepath=pddl%2Fparser%2Fdomain.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#diff-cGRkbC9wYXJzZXIvZG9tYWluLnB5) | `76.17% <100.00%> (ø)` | | | [pddl/parser/problem.py](https://app.codecov.io/gh/AI-Planning/pddl/pull/119?src=pr&el=tree&filepath=pddl%2Fparser%2Fproblem.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AI-Planning#diff-cGRkbC9wYXJzZXIvcHJvYmxlbS5weQ==) | `67.42% <100.00%> (ø)` | |