AI-SDC / ACRO

Tools for the Automatic Checking of Research Outputs. These are the tools for researchers to use as drop-in replacements for commands that produce outputs in Stata Python and R
MIT License
15 stars 2 forks source link

Code refactoring #195

Open mahaalbashir opened 8 months ago

mahaalbashir commented 8 months ago

Refactoring the function create_crosstab_masks in acro_table.

Looking at the levels of indentation and the numbers of lines in this method near where you calculate threshold masks etc., (lines 742 onwards) , I wonder if it is time to refactor some of this code into a series of functions called something like get_mask_for_aggfuncc()