search

AI-SDC / ACRO

Tools for the Automatic Checking of Research Outputs. These are the tools for researchers to use as drop-in replacements for commands that produce outputs in Stata Python and R
MIT License
15 stars 2 forks source link

fixes bug in way SDC info is displayed via prettify_table #202

Closed jim-smith closed 7 months ago

jim-smith commented 7 months ago

Bug arises due to the fact that prettify_table() use spaces to parse header data into column names Problem then arise when values of a field have spaces in them - so erroneous columns are created.

Fixed by replacing spaces with underscores in column names. In practice this does not affect the main output - just the display of the SDC 'masks' table to the user

notebooks.test.ipynb has a number of cells that show this fix in action. Functionality is tested via an addition to the testing of prettify_table() in test_initial.py

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.63%. Comparing base (444209b) to head (6f7b561).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #202 +/- ## ======================================= Coverage 99.63% 99.63% ======================================= Files 9 9 Lines 1092 1093 +1 ======================================= + Hits 1088 1089 +1 Misses 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.