Fix visible groups. Sort groups by scores. Close #150 Close #162

AI-comp / wpcs

2 stars 2 forks source link

Fix visible groups. Sort groups by scores. Close #150 Close #162 #164

Closed exKAZUu closed 11 years ago

exKAZUu commented 11 years ago

Close #150 Close #162

ss0201 commented 11 years ago

Group with lowest score takes 1st place!

coveralls commented 11 years ago

Coverage remained the same when pulling c8aefb1a9feb1c5a6be726910c5dacff64e9cdda on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.

coveralls commented 11 years ago

Coverage decreased (-1.14%) when pulling c8aefb1a9feb1c5a6be726910c5dacff64e9cdda on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.

ss0201 commented 11 years ago

Uh, did you miss my comment? https://github.com/TakenokoChocoHolic/wpcs/pull/164#issuecomment-17454537

coveralls commented 11 years ago

Coverage decreased (-1.24%) when pulling 42009c3bd40387744585931a30d578f334724a2b on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.

exKAZUu commented 11 years ago

What?

exKAZUu commented 11 years ago

This code work as follows.

A user can see only groups without admins.
An admin can see all groups.

coveralls commented 11 years ago

Coverage decreased (-1.24%) when pulling 42009c3bd40387744585931a30d578f334724a2b on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.

ss0201 commented 11 years ago

This code work as follows.

Yeah, and also "Sorts groups by scores," as you've mentioned in the commit message. I think groups are currently ordered in ascending order by their score.

exKAZUu commented 11 years ago

Oh, do you mean we should use desc instead of asc?

ss0201 commented 11 years ago

yeah why not. currently i can win by solving nothing.

ss0201 commented 11 years ago

did you confirm the scoreboard by your hand? untitled

ss0201 commented 11 years ago

Now fixed.

coveralls commented 11 years ago

Coverage decreased (-1.08%) when pulling 6fca7c8c8efd48cce66616461b9e394f8ffc5c5a on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.

exKAZUu commented 11 years ago

Actually, I did not test it :P I'd like useful test environment ( or a script for initializing test environment)...

ss0201 commented 11 years ago

Oh well. Here's a human tester (me :P).

coveralls commented 11 years ago

Coverage decreased (-1.24%) when pulling 6fca7c8c8efd48cce66616461b9e394f8ffc5c5a on 150_visible_groups into 85e9481d42f2e9a01346aec408a0ba8d7a40f321 on master.