search

AI-multimodal / aimmdb

BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Refactor schemas #40

Open matthewcarbone opened 1 year ago

matthewcarbone commented 1 year ago

Given we're now working on different types of schemas (we have an NMC one, we're developing a FEFF one and I'm hoping to develop more in the future), does it make sense to refactor schemas.py into a module itself? E.g.

schemas/
|---- base.py
|---- xas.py
|---- nmc.py
|---- feff.py
|---- ...

Where base.py contains GenericDocument, xas inherits base and the others inherit xas?

@danielballan @jmaruland thoughts?

danielballan commented 1 year ago

Fine by me!

jmaruland commented 1 year ago

I like this idea. It keeps files simple, as well

matthewcarbone commented 1 year ago

Excellent! I'll probably work with Mike a bit on this. Once we have a FEFF schema in place we'll make a new branch dedicated to the refactor.