Major issue in the MultiCrypto_Trading.ipynb: Changing the train time interval doesn't change the test results

AI4Finance-Foundation / FinRL-Meta

FinRL-Meta: Dynamic datasets and market environments for FinRL.

https://ai4finance.org

MIT License

1.24k stars 576 forks source link

Major issue in the MultiCrypto_Trading.ipynb: Changing the train time interval doesn't change the test results #160

Open mhdmyz opened 2 years ago

mhdmyz commented 2 years ago

There's a major issue in the MultiCrypto_Trading.ipynb! Changing the train time interval doesn't change the test results! For example in the original MultiCrypto_Trading.ipynb no matter what TRAIN_START_DATE and TRAIN_END_DATE you set, you'll get episode_return = 1.0837542090641283!