search

AI4Finance-Foundation / FinRL-Meta

FinRL­-Meta: Dynamic datasets and market environments for FinRL.
https://ai4finance.org
MIT License
1.28k stars 583 forks source link

Create FinRL_PortfolioAllocation_NeurIPS_2020.py #176

Closed mhdmyz closed 2 years ago

mhdmyz commented 2 years ago

Here's the .py file for Create FinRL_PortfolioAllocation_NeurIPS_2020

zhumingpassional commented 2 years ago

Good codes.

I have several revision suggestions, which can improve the code style:

  1. print should denotes the name of the variables, e.g., print(f"train.shape: {train.shape}")
  2. pls use DataProcessor in data_processor.py, e.g., DataProcessor(data_source='tushare', start_date=TRAIN_START_DATE, end_date=TRADE_END_DATE, time_interval=TIME_INTERVAL, **kwargs) The initialization is a little different.
  3. Preprocess Data should be revised. pls read the template https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/1-Introduction/China_A_share_market_tushare.py
  4. pls use "from finrl_meta import", instead of "from finrl import "

Could you please revise it according to the suggestions? Thanks very much for your codes.

mhdmyz commented 2 years ago

Sure! I'm working on it.

YangletLiu commented 2 years ago

How did it go? Do you encounter any trouble? Hope it goes smooth. @mhdmyz

zhumingpassional commented 2 years ago

thanks.

mhdmyz commented 2 years ago

Hi, Sorry I've been extremely busy the past few weeks! I made the changes you requested and created a pull request.