search

AI4Finance-Foundation / FinRL-Meta

FinRL­-Meta: Dynamic datasets and market environments for FinRL.
https://ai4finance.org
MIT License
1.2k stars 560 forks source link

Update FinRL_PortfolioAllocation_NeurIPS_2020.py #215

Closed mhdmyz closed 1 year ago

zhumingpassional commented 1 year ago

Thanks for your codes.

I still have several suggestions.

  1. It may be more available that only one file, 1-Introduction/FinRL_PortfolioAllocation_NeurIPS_2020.py , is revised. The PRs you submitted also have similar problems.
  2. we have changed the folder finrl-meta to meta. you may need to revise it. The PRs you submitted also have similar problems.
mhdmyz commented 1 year ago

You're welcome! I didn't understand your first point. Regarding your second point, I changed finrl-meta to meta in all pull requests I submitted.

zhumingpassional commented 1 year ago

In the first point, I mean, this PR only revises 1-Introduction/FinRL_PortfolioAllocation_NeurIPS_2020.py, and other files should not be change.

mhdmyz commented 1 year ago

Got you! It's because previously you requested replacing "from finrl import" with "from finrl_meta import" in this file, which results in multiple errors if done without modification of some dependencies. Because root of these errors was traced back to those dependencies.

mhdmyz commented 1 year ago

I believe the minor changes I made to those two dependencies will prevent and solve many existing errors as well.