search

AI4Finance-Foundation / FinRL-Tutorials

Tutorials. Please star.
https://ai4finance.org
MIT License
848 stars 349 forks source link

FinRL_MultiCrypto_Trading.py no longer working due to changes in ElegantRL and FinRL-Meta #61

Open roboalex2 opened 1 year ago

roboalex2 commented 1 year ago

Hi, there is quite a lot broken in the current version of FinRL_MultiCrypto_Trading.ipynb

See: https://github.com/AI4Finance-Foundation/FinRL-Meta/issues/291 Also see: #21

I am able to go around many of the problems by running old versions of the repos/dependencies but in the end i failed. As mentioned in one of the urls. Since Jan 2023 ElegantRL is no longer compatible.

/FinRL-Meta/agents/elegantrl_models.py is also no longer compatible due to line 58 (and more) changing Arguments(agent=agent, env=env) to Arguments(agent_class=agent, env=env)

ray.rllib also seems to have had some breaking changes. Also tried version 2.0.0 since its from around date the tutorial was moved into this repo but still didn't work.

Please fix the tutorials. I realy would like to get started looking into FinRL.

eervin123 commented 1 year ago

I would love this as well. I spent more time than I would like to admit trying to get the imports to work. I was hoping to be able to solve most of the problems so I could contribute but there were too many and I'm not familiar enough with the history of the repo to be able to point someone in the right direction.