AI4Finance-Foundation / FinRL

FinRL: Financial Reinforcement Learning. 🔥
https://ai4finance.org
MIT License
9.4k stars 2.29k forks source link

Installation process can skip cuda-pytorch #1023

Closed icsl-Jeon closed 1 year ago

icsl-Jeon commented 1 year ago

Describe the bug

Thank you for wonderful OpenSource project!

The installation guide here, which uses pip install ., can install pytorch cpu version. If this is the case, users cannot use gpu when training.

I think it would be better to instruct users that the below pytorch install might be required pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu117

To Reproduce We can simply check the below after installing FinRL on a clean conda env.

import torch
torch.cuda.is_available()
YangletLiu commented 1 year ago

Describe the bug

Thank you for wonderful OpenSource project!

The installation guide here, which uses pip install ., can install pytorch cpu version. If this is the case, users cannot use gpu when training.

I think it would be better to instruct users that the below pytorch install might be required pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu117

To Reproduce We can simply check the below after installing FinRL on a clean conda env.

import torch
torch.cuda.is_available()

Thanks very much for this feedback!

zhumingpassional commented 1 year ago

@icsl-Jeon thanks for your suggestions w.r.t torch, it depends on users' demand, e.g., OS, gpu/cpu the install docs focus on installing finrl