AI4Finance-Foundation / FinRL

FinRL: Financial Reinforcement Learning. 🔥
https://ai4finance.org
MIT License
10.16k stars 2.45k forks source link

Refactor FeatureEngineer to accept df in preprocess_data() #25

Closed spencerR1992 closed 3 years ago

spencerR1992 commented 3 years ago

Implementing the class without the DF parameter will allow this to be re-used in other contexts without being re-initialized. This could be useful in designing backtesting.

YangletLiu commented 3 years ago

Not understand. But you can try and pull a request, we are happy to include such a feature/function.

BruceYanghy commented 3 years ago

Implementing the class without the DF parameter will allow this to be re-used in other contexts without being re-initialized. This could be useful in designing backtesting.

Thank you so much!! Did you join our slack open community?

https://join.slack.com/t/ai4financeworkspace/shared_invite/zt-jyaottie-hHqU6TdvuhMHHAMXaLw_~w

BruceYanghy commented 3 years ago

Implementing the class without the DF parameter will allow this to be re-used in other contexts without being re-initialized. This could be useful in designing backtesting.

Maybe you can join us for our academic research papers in 2021. FinRL is our DRL framework, we can always refer back to this repo to do the coding for our new papers, we have some research initiatives in our mind for ICAIF 2021:

Research Initiatives: