search

AI4Finance-Foundation / FinRL

FinRL: Financial Reinforcement Learning. 🔥
https://ai4finance.org
MIT License
9.4k stars 2.29k forks source link

There is a problem with the buy and sell operation in the env_stocktrading_np file #994

Open dd-python opened 1 year ago

dd-python commented 1 year ago

When tested with the env_stocktrading_np environment, the action to sell the stock does not take into account whether the stock is currently held

zhumingpassional commented 1 year ago

we have not updated it. pls use env_stocktrading.py

dd-python commented 1 year ago

Thank you for your reply

------------------ 原始邮件 ------------------ 发件人: "Ming @.>; 发送时间: 2023年5月2日(星期二) 上午9:17 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [AI4Finance-Foundation/FinRL] There is a problem with the buy and sell operation in the env_stocktrading_np file (Issue #994)

we have not updated it. pls use env_stocktrading.py

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

julianzero commented 1 year ago

we have not updated it. pls use env_stocktrading.py

ElegantRL only works with env_stocktrading_np so I have done all the work with env_stocktrading_np. Is it wrong?

Thanx.

julianzero commented 1 year ago

we have not updated it. pls use env_stocktrading.py

I have revised env_stocktrading_np, and firmly believe it is correct.

env_stocktrading.py involves too many parameters, can you give an example of the input arguments?

Thanx.