AI4OPT / OPFGenerator

Instance generator for OPF problems
MIT License
2 stars 3 forks source link

Add support for SOCWRConicPowerModel formulation #30

Closed mtanneau closed 11 months ago

mtanneau commented 11 months ago

This PR also streamlines unit tests considerably, by leveraging the PowerModels type hierarchy

mtanneau commented 11 months ago

cc @ccoffrin I implemented the SOCWRConic on top of the SOCWR. There are only 3 constraints that differ between the two formulations.

If relevant for https://github.com/lanl-ansi/PowerModelsAnnex.jl/issues/22 I can implement something similar there?

For completeness: https://github.com/AI4OPT/OPFGenerator/blob/d9fa2782bbff804cc5a7127c7e3c2ee53f9dac20/src/opf/socwr.jl#L118-L124 and https://github.com/AI4OPT/OPFGenerator/blob/d9fa2782bbff804cc5a7127c7e3c2ee53f9dac20/src/opf/socwr.jl#L128-L138

ccoffrin commented 11 months ago

I think my primary motivation with https://github.com/lanl-ansi/PowerModelsAnnex.jl/issues/22 was to get the OTS version in there so folks could have an OTS lower bound model to play around with. Back in 2018, Gurobi's MIQCQP solver was one of the few working options, now there are more. I have not seen a big demand for the SOCWRConic model of late so I would probably just close out https://github.com/lanl-ansi/PowerModelsAnnex.jl/issues/22