search

AI4OPT / OPFGenerator

Instance generator for OPF problems
MIT License
2 stars 3 forks source link

Export reserve data in input H5 #99

Open klamike opened 1 week ago

klamike commented 1 week ago

Economic Dispatch exports the reserve data as part of the solution even though it's really an input, since the schema for the input H5 in exp/sampler.jl doesn't include reserve data:

https://github.com/AI4OPT/OPFGenerator/blob/4a1f1178a36d0b8edb14fa5a13bf5dd5b4a75109/exp/sampler.jl#L128-L135

klamike commented 1 week ago

Also, rmin and rmax are the same across samples, so they should go in the <casename>.ref.json file instead of the solution.

https://github.com/AI4OPT/OPFGenerator/blob/4a1f1178a36d0b8edb14fa5a13bf5dd5b4a75109/src/opf/ed.jl#L470-L471

mtanneau commented 1 week ago

I'm OK with both