Closed KennyDizi closed 9 months ago
๐ฏ Main theme: Restricting pipeline triggers and deployment conditions in GitHub Actions workflow
๐ PR summary: This PR modifies the GitHub Actions workflow configuration to limit the pipeline triggers to 'push' events on 'main', 'stg', and 'dev' branches, and 'pull_request' events on the 'dev' branch only. It also removes the condition for deploying to AWS using CDK, meaning the deployment will run unconditionally within the workflow.
๐ Type of PR: Enhancement
๐งช Relevant tests added: No
โฑ๏ธ Estimated effort to review [1-5]: 1, because the changes are straightforward and limited to the GitHub Actions workflow configuration.
๐ Security concerns: No security concerns found
๐ก General suggestions: The changes made in this PR are clear and straightforward. However, it would be beneficial to include a rationale for these changes in the PR description. This would help reviewers understand the context and the need for these changes.
type:
enhancement
description:
This PR modifies the GitHub Actions workflow configuration to restrict the pipeline triggers and deployment conditions. The changes include:
main_files_walkthrough:
files:
- `.github/workflows/release.yml`: The changes in the 'release.yml' file include the removal of 'stg' and 'main' from the 'pull_request' trigger branches, and the removal of the condition for the 'Deploy to AWS using CDK' job.