AI4S2S / lilio

Calendar generator for machine learning with timeseries data
https://lilio.readthedocs.io/en/latest/
Apache License 2.0
5 stars 1 forks source link

Implement alternative resampling methods #30

Closed BSchilperoort closed 1 year ago

BSchilperoort commented 1 year ago

Users may want to use different statistics rather than "mean" for their resampling. This PR adds that functionality. All of the following (numpy) statistics are supported:

Additionally, user defined functions can also be passed.

Tasks:

Note: the traintest tests had to be updated due to the change in the sorting of the anchor years in the xarray output of resample.

Closes #4

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

BSchilperoort commented 1 year ago

Note that the md link check fails. This is fixed in #28, so I won't fix the link here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.1% 93.1% Coverage
0.0% 0.0% Duplication

geek-yang commented 1 year ago

The custom function looks good and works well too. Let's merge this PR!

BSchilperoort commented 1 year ago

Thanks for the reviews @geek-yang !