Closed geek-yang closed 1 year ago
Alright...the failing CI seems to imply that the wheel of numpy
for python 3.11 is not available yet. Found some similar issue with py3.10 before (check this)...Update pip
and pin version of numpy
do not help. But this is very strange...As in zampy
it works and we have the same setup for CD/CI and project.toml. Any idea about it? @BSchilperoort
Just spotted a typo, otherwise it looks good.
Perhaps it can also be good to set mypy's python version? I believe it spots old syntax that can now be typed in a nicer way (such as
List
->list
,Union[a, b]
toa | b
).
I thought about it indeed, but the type union |
thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?
I thought about it indeed, but the type union
|
thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?
I just meant it as an example, so if we change the mypy version (eventually) to 3.10, then mypy will tell us we can use the |
as OR.
I thought about it indeed, but the type union
|
thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?I just meant it as an example, so if we change the mypy version (eventually) to 3.10, then mypy will tell us we can use the
|
as OR.
I got it now! That sounds good! I will add a line python_version = "3.10"
Kudos, SonarCloud Quality Gate passed!
xarray
not support 3.8 anymore)