AI4S2S / lilio

Calendar generator for machine learning with timeseries data
https://lilio.readthedocs.io/en/latest/
Apache License 2.0
5 stars 1 forks source link

Support python3.11 and bump version #60

Closed geek-yang closed 1 year ago

geek-yang commented 1 year ago
geek-yang commented 1 year ago

Alright...the failing CI seems to imply that the wheel of numpy for python 3.11 is not available yet. Found some similar issue with py3.10 before (check this)...Update pip and pin version of numpy do not help. But this is very strange...As in zampy it works and we have the same setup for CD/CI and project.toml. Any idea about it? @BSchilperoort

geek-yang commented 1 year ago

Just spotted a typo, otherwise it looks good.

Perhaps it can also be good to set mypy's python version? I believe it spots old syntax that can now be typed in a nicer way (such as List -> list, Union[a, b] to a | b).

I thought about it indeed, but the type union | thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?

BSchilperoort commented 1 year ago

I thought about it indeed, but the type union | thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?

I just meant it as an example, so if we change the mypy version (eventually) to 3.10, then mypy will tell us we can use the | as OR.

geek-yang commented 1 year ago

I thought about it indeed, but the type union | thingy is supported from python 3.10 (https://docs.python.org/3/whatsnew/3.10.html), and it does not work with python 3.9, which could cause issue for CD/CI, right?

I just meant it as an example, so if we change the mypy version (eventually) to 3.10, then mypy will tell us we can use the | as OR.

I got it now! That sounds good! I will add a line python_version = "3.10"

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication