search

AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

RGDR: renamed plot->preview, tutorial improved #106

Closed BSchilperoort closed 2 years ago

BSchilperoort commented 2 years ago

In issue #102 we discussed if the preview method were necessary or confusion to users. The conclusion was that they can be very useful for tuning RGDR, but their naming can cause confusion.

To this end, the preview methods have been renamed to preview_correlation and preview_clusters to properly reflect their purpose. The RGDR notebook has also been updated, both to reflect the renaming, as well as extra examples on how the corr_map, pval_map and cluster_map DataArrays can be retrieved and visualized.

The updated notebook can be viewed here

Closes #102

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication