Rebase BaseCalendar to CustomCalendar

[geek-yang]

Replace BaseCalendar with CustomCalendar, which includes following steps:

• [x] Replace BaseCalendar with CustomCalendar
• [x] Refactor AdvantCalendar based on the new BaseCalendar
• [x] Refactor MonthlyCalendar and WeeklyCalendarbased on the new BaseCalendar
• [x] Update (relevant) example notebooks
• [x] Fix all tests in time module

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[geek-yang]

Hi Yang, good job! I did find some small bugs, but that's expected with such a big overhaul!

I noticed that the tutorial_resampling_data is not updated, and does not work at the moment (anchor definition is incorrect). Can you update that for this PR?

Also, I am not a big fan of splitting the calendar explanations over multiple notebooks. How about just two? One for the Advent/Monthly/Weekly calendars, and one for the CustomCalendar? Or one main one using only the Advent calendar, and then a notebook about alternatives?

Thanks for the review! 😂 I forgot the tutorial_resampling_data. Thanks for noticing this. I will fix it.

And I like your idea about only keeping the adventcalendar notebook and merge the others as one alternative_calendar notebook. I will implement this. 👍

[geek-yang]

For the other tests (e.g. test_resample.py), it is not relevant with this one and let's fix them in next PR, where I would like to fix traintest and RGDR.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

88.0% Coverage
0.0% Duplication