AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Reworked label alignment into RGDR #139

Closed BSchilperoort closed 1 year ago

BSchilperoort commented 1 year ago

This PR implements label alignment over splits into RGDR. The label alignment is aimed at giving similar clusters over different splits the same name, while not changing the actual data (avoiding any train-test leakage).

An example of the final result can be visualized using the following plot: image

Label alignment is performed by the user as follows: s2spy.rgdr.label_alignment.rename_labels(rgdrs, clustered_data) Where rgdrs is a list of RGDR objects, and clustered_data is data that has been clustered using that RGDR object. This can be both the train data as well as the test data.

A new notebook has been added, `example_label_alignment.ipnb" which walks through the train test splitting as well as the label alignment steps.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

10.3% 10.3% Coverage
0.0% 0.0% Duplication

BSchilperoort commented 1 year ago

CI seems borked.

Peter9192 commented 1 year ago

https://www.urbandictionary.com/define.php?term=borked

Cool, didn't know that word ^^