AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

repr improvements #140

Closed BSchilperoort closed 1 year ago

BSchilperoort commented 1 year ago

This PR tries to tackle the comments @Peter9192 had on the reprs and serializability of the calendars.

List of changes:

New repr example:

>>> calendar
Calendar(
    anchor='12-31',
    allow_overlap=False,
    mapping=('years', 2000, 2020),
    intervals=[
        Interval(role='target', length='20d', gap='0d'),
        Interval(role='target', length='20d', gap='10d'),
        Interval(role='precursor', length='10d', gap='-5d'),
        Interval(role='precursor', length='2W', gap='0d'),
        Interval(role='precursor', length='1M', gap='0d')
    ]
)
review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.2% 88.2% Coverage
0.0% 0.0% Duplication