AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Support monthly and weekly data for preprocess module #173

Closed geek-yang closed 1 year ago

geek-yang commented 1 year ago

Support monthly/weekly data in preprocess by providing a timescale argument to the user.

This closes #168 and closes #160 .

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

BSchilperoort commented 1 year ago

But since it only relates to the preparation of testing data, not about the code. I simply silent it for python 3.8

It's not ideal, but I also wouldn't want to spend too much time on that. Perhaps we have to deprecate python 3.8 anyway: xarray isn't supporting it anymore for new releases.

geek-yang commented 1 year ago

But since it only relates to the preparation of testing data, not about the code. I simply silent it for python 3.8

It's not ideal, but I also wouldn't want to spend too much time on that. Perhaps we have to deprecate python 3.8 anyway: xarray isn't supporting it anymore for new releases.

I agree. Let's drop python 3.8.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

semvijverberg commented 1 year ago

Thanks @geek-yang @BSchilperoort!