search

AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Implement lag shift trim (discard) function #20

Closed geek-yang closed 2 years ago

geek-yang commented 2 years ago

As a user, I want to obtain the intervals with preferred time lag for my target period. The rest will be discarded.

This PR closes issue #19 .

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

geek-yang commented 2 years ago

This PR involves too much old design which has been replaced by new implementations. In order to keep the codebase clean, I will close this PR and implement the discard function based on the latest codebase.