AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

New name for column 'lag' in function map_to_data in time.py #24

Closed jannesvaningen closed 2 years ago

jannesvaningen commented 2 years ago

We need a new name for the column name 'lag' in the function map_to_data. https://github.com/AI4S2S/ai4s2s/blob/fa0ad6508b7c1f9e294adfde527c786e7a8f7b8c/s2s/time.py#L176 The name lag does not quite cut it, because it does not acknowledge that the first period after the next target period is also lag 1,2,3 etc. Current suggestions:

BSchilperoort commented 2 years ago

Fixed by #28