AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Implemented dbscan for RGDR #57

Closed BSchilperoort closed 2 years ago

BSchilperoort commented 2 years ago

Implements dbscan clustering functionality. The code included in here is sufficient to reproduce the prototype_RGDR notebook. See the wip notebook


From @geek-yang:

When these methods are implemented, we also need to validate the results:

Note: For RGDR we will want to support grouping the DBSCAN operations over splits, due to the computational intensity when working with full resolution data, see #58

This PR fixes #55


Still to be implemented, but out of scope for this PR:

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

BSchilperoort commented 2 years ago

Note that the Python 3.7 Windows build fails. This is due to an issue with the netcdf4 package, which has become a dependency to be able to use the example data from the proto.

To silence this issue we can specify the version for netcdf4, which might resolve the error. However, for how long do we want to keep supporting Python 3.7? It will reach its end of life in a couple of months.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.6% 96.6% Coverage
0.0% 0.0% Duplication