search

AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Add mypy #66

Closed Peter9192 closed 2 years ago

Peter9192 commented 2 years ago

Added to Prospector or run as standalone:

# in root dir
prospector

# or
mypy s2spy --ignore-missing-imports

This PR also updates the python version for GH actions to 3.10, for there have been substantial improvements in the type hint system recently.

Note: some broken types will be superseded by #60

Peter9192 commented 2 years ago

Getting different results on GH actions and locally... 😕

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Peter9192 commented 2 years ago

Getting different results on GH actions and locally... 😕

It appears this was due to the pip instruction in the GH Action workflow actually creating a build directory, so there was a duplicate between src and build directories. Excluding build in the prospector config file solved the issue. Now the remaining errors are the same I get locally.