Closed BSchilperoort closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hi Yang, thanks for the review. RGDR does feel cluttered, however it currently only contains the following;
__init__
I think the size and structure of the file is fine at the moment. We could move out the correlation method along with the pearsonr_nan function, but that would indeed be appropriate to do when implementing different correlation/regression methods.
We could refactor it to something like;
utils.py
utils.py
utils.py
correlation.py
correlation.py
__init__
Kudos, SonarCloud Quality Gate passed!
This PR implements RGDR as a class, with the previously implemented DBSCAN functionality integrated into the class, and with plotting methods available for users to play with the RGDR configuration.
Note that this is a standalone implementation of RGDR, without any knowledge about splits/folds implemented explicitly.
Example:
Closes #38