In PR #60 the AdventCalendar is refactored to be a child of a BaseCalendar.
However, setter and getter methods have not been explicitly implemented, allowing users to modify the calendar as such:
>>> cal = AdventCalendar(anchor=(25, 12), freq='1d')
>>> cal.freq = '5d'
>>> cal.show()
# will show calendar with 5-day frequency
The calendar will actually use the changed frequency, but the frequency is actually not checked for validity. The following will not immediately raise an error:
cal.freq = 'abc'
The anchor also cannot be changed directly, but can be changed as such:
cal.day = 31
We should decide if we will allow modifying the calendar after initialization, or if we want to make the attributes read-only.
BSchilperoort
commented
1 year ago
In PR #60 the
AdventCalendaris refactored to be a child of aBaseCalendar.However, setter and getter methods have not been explicitly implemented, allowing users to modify the calendar as such:
The calendar will actually use the changed frequency, but the frequency is actually not checked for validity. The following will not immediately raise an error:
The anchor also cannot be changed directly, but can be changed as such:
We should decide if we will allow modifying the calendar after initialization, or if we want to make the attributes read-only.