Implement train/test splits iterator

AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting

https://ai4s2s.readthedocs.io/

Apache License 2.0

20 stars 7 forks source link

Implement train/test splits iterator #74

Closed geek-yang closed 2 years ago

geek-yang commented 2 years ago

In this PR we implement an iterator for train/test splits, which enable the user to easily fetch train/test data from each split. The potential usecases are listed in issue AI4S2S/s2spy#71.

[x] Create generator function for train/test iteration in traintest.py
[x] ~Support xr.Dataset and pd.DataFrame~ Only xarray
[x] Add examples in notebooks.
[x] Support multiple inputs

This PR closes AI4S2S/s2spy#71. And AI4S2S/lilio#46

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Peter9192 commented 2 years ago

Finally, green CI! @geek-yang @semvijverberg please briefly review as we've already discussed it yesterday. Since then I've added tests, tests, tests, type annotations, and some additional sanity checks.

geek-yang commented 2 years ago

@Peter9192 Nice work! The implementation is very elegant! I have a few very small comments to add. Since this PR is opened by me, I can not approve it. I would prefer @semvijverberg to take care of it. Well done!

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

89.4% Coverage
0.0% Duplication