AI4S2S / s2spy

A high-level python package integrating expert knowledge and artificial intelligence to boost (sub) seasonal forecasting
https://ai4s2s.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Now storing corr, pval & cluster_map into rgdr instance #94

Closed semvijverberg closed 2 years ago

semvijverberg commented 2 years ago

Concerning issue #91 .

To allow users to inspect the output of RGDR in hindsight, I have added corr_map, pval_map, and cluster_map to the instance that is created after fitting, i.e., RGDR().fit(field, timeseries).

This means that the hidden rgdr._clusters which was already stored on the instance is now visible as 'rgdr.cluster_map'.

In the tutorial_RGDR.ipynb, I have a added a single cell, where corr_map is plotted after calling rgdr.fit().

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication