search

AICAN-Research / FAST-Pathology

⚡ Open-source software for deep learning-based digital pathology
BSD 2-Clause "Simplified" License
121 stars 24 forks source link

macOS installer #52

Closed andreped closed 1 year ago

andreped commented 1 year ago

After some trial and error, I managed to create an installer for macOS. It is based on the Bundle CPack Generator.

What's changed:

As can be seen below, there is a minor issue that should be addressed in the future, but I believe that is not critical for this PR.

After installing the program, when running it you are prompted: "FastPathology" cannot be opened because the developer cannot be verified. macOS cannot verify that this app is free from malware.

To get it to work, you need to go to /Applications/FastPathology.app and right-click run the software the first time after installation. By doing so, you should now be given the option to Open the app, which will by-pass the issue seen above.

Is there a good way of fixing this? Right now when installing the software, I was not prompted to say whether I was admin or not. For other Python apps based on PackageMaker-like generator, I was prompted to show that I was admin and in that case it worked fine. I had not signed the app or anything like that. It just worked. Hence, I found it strange that this was an issue for the C++ application. Any ideas? I also tried changing generator, but I am less familiar with those generators, hence I was unable to get them working in a similar manner as with Bundle.

andreped commented 1 year ago

Made some additional tests, but can't get it to work as intended. Currently, it is required to right-click + open first time running the software to bypass the "unknown developer" issue.

andreped commented 1 year ago

According to @olevs, CustusX is having the exact same problem with the installer.

CustusX is using the same Bundle/DragNDrop CPack generator as in this PR.

Switching to another generator could solve this issue, but that is outside the scope of this PR.

If there are no other concerns, this PR could therefore be merged.

andreped commented 1 year ago

@smistad shouldn't this have been merged before the release, such that macOS users have an easier time using FP? This simply generates an APP bundle, which can be run as any other application.