search

AICC / CMI-5_Spec_Current

cmi5
http://adlnet.gov
Apache License 2.0
181 stars 91 forks source link

Make JSON and Markdown formatting consistent across all samples #713

Closed thomasturrell closed 3 years ago

thomasturrell commented 3 years ago
thomasturrell commented 3 years ago

When reviewing this pull request it might be useful to ignore whitespace changes so you can see the syntax fixes.

I have used Prettier which is a Visual Studio Code plug in to format the JSON.

brianjmiller commented 3 years ago

If we're going to make this significant of a change I'd also advocate for dropping the properties in the statements that are from them being captured in the LRS as opposed to what is to be sent. Things like stored, and authority. The original samples didn't include those since it was intended to be what would be sent from the AU/LMS rather than what would be read back out afterwards. Though they should have an understanding of xAPI I'd rather people not think they can set those properties based on these samples.

thomasturrell commented 3 years ago

I'd also advocate for dropping the properties in the statements that are from them being captured in the LRS as opposed to what is to be sent. Things like stored, and authority.

I completely agree. I'm happy to do it, let's discuss on working group call.

cawerkenthin commented 3 years ago

👍

MrBillMcDonald commented 3 years ago

Closed per Aug 13th Meeting